[webkit-reviews] review denied: [Bug 26755] bugzilla-tool's commit messages are lacking for patches with multiple ChangeLogs : [Attachment 44296] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Fri Dec 4 00:39:32 PST 2009


Adam Barth <abarth at webkit.org> has denied Adam Barth <abarth at webkit.org>'s
request for review:
Bug 26755: bugzilla-tool's commit messages are lacking for patches with
multiple ChangeLogs
https://bugs.webkit.org/show_bug.cgi?id=26755

Attachment 44296: Patch
https://bugs.webkit.org/attachment.cgi?id=44296&action=review

------- Additional Comments from Adam Barth <abarth at webkit.org>
In trying to write a unit test for this patch, we discovered that
commit-log-editor is super fragile and has a number of error conditions that
are very complex to recover from.  I no longer think this is the right
approach.  We need a simpler way of creating commit messages that is testable.


More information about the webkit-reviews mailing list