[webkit-reviews] review requested: [Bug 31716] Cache the validation result of a form control : [Attachment 44282] Proposed patch (rev.3)

[bugzilla-daemon at webkit.org]

TAMURA, Kent <tkent at chromium.org> has asked  for review:
Bug 31716: Cache the validation result of a form control
https://bugs.webkit.org/show_bug.cgi?id=31716

Attachment 44282: Proposed patch (rev.3)
https://bugs.webkit.org/attachment.cgi?id=44282&action=review

------- Additional Comments from TAMURA, Kent <tkent at chromium.org>
(In reply to comment #10)
> But aren't you also replacing some setNeedsStyleRecalc calls in code paths
that
> previously had them for other reasons?

Ah, yes.  min/max attributes for type=range require setNeedsStyleRecalc()
regardless validity status. Thank you for pointing out.

I split and renamed the method:
  updateValidityAndStyle() - should be called when validity status can be
changed and the appearance should be changed regardless the validity
  updateValidityAndStyleIfNeeded() - should be called when validity status can
be changed.  setNeedsStyleRecalc() is called only if the validity status is
changed.