[webkit-reviews] review granted: [Bug 32111] Geolocation bug causes crash when watch is cleared from some callbacks : [Attachment 44241] Patch 1 for Bug 32111

[bugzilla-daemon at webkit.org]

Darin Adler <darin at apple.com> has granted Steve Block <steveblock at google.com>'s
request for review:
Bug 32111: Geolocation bug causes crash when watch is cleared from some
callbacks
https://bugs.webkit.org/show_bug.cgi?id=32111

Attachment 44241: Patch 1 for Bug 32111
https://bugs.webkit.org/attachment.cgi?id=44241&action=review

------- Additional Comments from Darin Adler <darin at apple.com>
> +    // Cache our pointer to the Geolocation object, as this GeoNotifier
object
> +    // could be deleted by a call to clearWatch in a callback.
> +    Geolocation* geolocation = m_geolocation;

Since the Geolocation object is reference counted, shouldn't this be a RefPtr?
If not, then why is the Geolocation object reference counted? In other words,
what guarantees it will not be destroyed?