[webkit-reviews] review granted: [Bug 30256] ~96 regression tests fail when using QuickTime 7.6 (they pass with QuickTime 7.3) : [Attachment 44267] Simplified patch.
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Thu Dec 3 13:47:22 PST 2009
Adam Roben (aroben) <aroben at apple.com> has granted Eric Carlson
<eric.carlson at apple.com>'s request for review:
Bug 30256: ~96 regression tests fail when using QuickTime 7.6 (they pass with
QuickTime 7.3)
https://bugs.webkit.org/show_bug.cgi?id=30256
Attachment 44267: Simplified patch.
https://bugs.webkit.org/attachment.cgi?id=44267&action=review
------- Additional Comments from Adam Roben (aroben) <aroben at apple.com>
> + // Read the current PATH.
> + DWORD pathSize = GetEnvironmentVariableW(pathEnvironmentVariable, 0, 0);
> + Vector<TCHAR> oldPath(pathSize);
> + if (!GetEnvironmentVariable(pathEnvironmentVariable, oldPath.data(),
oldPath.size()))
> + return;
That should be Vector<WCHAR>.
r=me
More information about the webkit-reviews
mailing list