[webkit-reviews] review requested: [Bug 32115] document.cookie accessors should raise INVALID_STATE_ERR if there is no browsing context : [Attachment 44239] Revised more tests.
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Thu Dec 3 07:09:04 PST 2009
Patrik Persson <patrik.j.persson at ericsson.com> has asked for review:
Bug 32115: document.cookie accessors should raise INVALID_STATE_ERR if there is
no browsing context
https://bugs.webkit.org/show_bug.cgi?id=32115
Attachment 44239: Revised more tests.
https://bugs.webkit.org/attachment.cgi?id=44239&action=review
------- Additional Comments from Patrik Persson <patrik.j.persson at ericsson.com>
I completely missed the fact that three existing tests broke with this
change. Sorry about this. This patch includes those tests.
The tests didn't expect exceptions to be raised. Rather, they simply
expected to receive an empty string when reading the cookie attribute
of a document created using document.implementation.create[HTML]Document.
One new test case replaces another case. I placed the new case in
'fast/cookies' to be able to use the JavaScript framework
(shouldThrow, shouldBe) for checks.
Anyway, before we get into the details of testing this, we should
decide whether to raise an exception at all.
More information about the webkit-reviews
mailing list