[webkit-reviews] review denied: [Bug 31591] [Qt] Crashing tests after updating to Qt-4.6.0 : [Attachment 44147] patch v2
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Thu Dec 3 04:37:51 PST 2009
Kenneth Rohde Christiansen <kenneth at webkit.org> has denied Andras Becsi
<abecsi at inf.u-szeged.hu>'s request for review:
Bug 31591: [Qt] Crashing tests after updating to Qt-4.6.0
https://bugs.webkit.org/show_bug.cgi?id=31591
Attachment 44147: patch v2
https://bugs.webkit.org/attachment.cgi?id=44147&action=review
------- Additional Comments from Kenneth Rohde Christiansen
<kenneth at webkit.org>
r- for comments given on irc
Mostly style issues like:
QWebPage* page =static_cast<QWebPage *>(new WebPage(container, this));
which should be
QWebPage* page = static_cast<QWebPage*>(new WebPage(container, this));
etc
More information about the webkit-reviews
mailing list