[webkit-reviews] review granted: [Bug 32079] Undo should not affect elements that are not editable : [Attachment 44170] patch

[bugzilla-daemon at webkit.org]

Adele Peterson <adele at apple.com> has granted Enrica Casucci
<enrica at apple.com>'s request for review:
Bug 32079: Undo should not affect elements that are not editable
https://bugs.webkit.org/show_bug.cgi?id=32079

Attachment 44170: patch
https://bugs.webkit.org/attachment.cgi?id=44170&action=review

------- Additional Comments from Adele Peterson <adele at apple.com>
Are there cases where the parent isn't editable, and its not attached, where we
would want to allow the AppendNodeCommand?

>  void AppendNodeCommand::doApply()
>  {
> +    if (!m_parent->isContentEditable() && m_parent->attached())
> +	   return;
> +	   
>      ExceptionCode ec;
>      m_parent->appendChild(m_node.get(), ec);
>  }