[webkit-reviews] review granted: [Bug 32103] Add zombies to JSC : [Attachment 44209] Patch

[bugzilla-daemon at webkit.org]

Gavin Barraclough <barraclough at apple.com> has granted Oliver Hunt
<oliver at apple.com>'s request for review:
Bug 32103: Add zombies to JSC
https://bugs.webkit.org/show_bug.cgi?id=32103

Attachment 44209: Patch
https://bugs.webkit.org/attachment.cgi?id=44209&action=review

------- Additional Comments from Gavin Barraclough <barraclough at apple.com>
> -#define COLLECT_ON_EVERY_ALLOCATION 0
> +#define COLLECT_ON_EVERY_ALLOCATION 1

Yeah, I don't think you mean that.  I'm only guessing.

> -			   imp->~JSCell();
> +#if ENABLE(JSC_ZOMBIES)
> +			   if (!imp->isZombie()) {
> +			       const ClassInfo* info = imp->classInfo();
> +#endif
> +			       imp->~JSCell();
> +#if ENABLE(JSC_ZOMBIES)
> +			       new (imp) JSZombie(info,
JSZombie::leakedZombieStructure());
> +			       heap.numZombies++;
> +			   }
> +#endif

Personally I think this might be a little nicer as:

#if ENABLE(JSC_ZOMBIES)
			if (!imp->isZombie()) {
			    const ClassInfo* info = imp->classInfo();
			    imp->~JSCell();
			    new (imp) JSZombie(info,
JSZombie::leakedZombieStructure());
			    heap.numZombies++;
			}
#else
			imp->~JSCell();
#endif


BRRrrrraaaiiiiiinnnnzzzzzzzzzzzzzzzzzzzzz+