[webkit-reviews] review granted: [Bug 32048] [chromium] theme scrollbars to match gtk theme : [Attachment 44173] patch with fixed tabs and caps
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Wed Dec 2 13:00:13 PST 2009
Eric Seidel <eric at webkit.org> has granted Evan Martin <evan at chromium.org>'s
request for review:
Bug 32048: [chromium] theme scrollbars to match gtk theme
https://bugs.webkit.org/show_bug.cgi?id=32048
Attachment 44173: patch with fixed tabs and caps
https://bugs.webkit.org/attachment.cgi?id=44173&action=review
------- Additional Comments from Eric Seidel <eric at webkit.org>
WebKit doesn't get excited about wrapping:
154 SkColorToHSV(RenderThemeChromiumLinux::thumbInactiveColor(),
155 thumb_hsv);
This looks fine though.
I'm slightly surprised you need both:
+#include "RenderTheme.h"
+#include "RenderThemeChromiumLinux.h"
More information about the webkit-reviews
mailing list