[webkit-reviews] review requested: [Bug 32076] Web Inspector: Simplify the settings support in inspector controller. : [Attachment 44174] [PATCH] Proposed change

[bugzilla-daemon at webkit.org]

Pavel Feldman <pfeldman at chromium.org> has asked  for review:
Bug 32076: Web Inspector: Simplify the settings support in inspector
controller.
https://bugs.webkit.org/show_bug.cgi?id=32076

Attachment 44174: [PATCH] Proposed change
https://bugs.webkit.org/attachment.cgi?id=44174&action=review

------- Additional Comments from Pavel Feldman <pfeldman at chromium.org>
This change makes everything String. It supports reading boolean properties
from the legacy store in order to properly handle debugger/profiles/resources
enabled state. However, it does not read numbers properly - users will lose
preferred attached height once migrated (only once). I think it is reasonable
compromise given that all supporting code can be deleted...