[webkit-reviews] review denied: [Bug 32054] Asynchronous Icon loading support : [Attachment 44130] Proposed patch (rev.2)

[bugzilla-daemon at webkit.org]

Sam Weinig <sam at webkit.org> has denied TAMURA, Kent <tkent at chromium.org>'s
request for review:
Bug 32054: Asynchronous Icon loading support
https://bugs.webkit.org/show_bug.cgi?id=32054

Attachment 44130: Proposed patch (rev.2)
https://bugs.webkit.org/attachment.cgi?id=44130&action=review

------- Additional Comments from Sam Weinig <sam at webkit.org>
>	   virtual void runOpenPanel(Frame*, PassRefPtr<FileChooser>) = 0;
> +	   // Asynchronous request to load an icon for specified filenames.
> +	   // This is called only if Icon::createIconForFiles() returns 0.
> +	   virtual void iconForFiles(const Vector<String>&,
PassRefPtr<FileChooser>) { };

This should be pure-virtual and implemented in each ports WebKit layer.

r-.