[webkit-reviews] review granted: [Bug 31617] WebSocket handshake doesn't check query component of URL : [Attachment 44127] WebSocket handshake check query component of URL

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue Dec 1 23:41:26 PST 2009


Alexey Proskuryakov <ap at webkit.org> has granted Fumitoshi Ukai
<ukai at chromium.org>'s request for review:
Bug 31617: WebSocket handshake doesn't check query component of URL
https://bugs.webkit.org/show_bug.cgi?id=31617

Attachment 44127: WebSocket handshake check query component of URL
https://bugs.webkit.org/attachment.cgi?id=44127&action=review

------- Additional Comments from Alexey Proskuryakov <ap at webkit.org>
r=me, thanks for adding all these tests!

It worries me that accidentally using localhost instead of 127.0.0.1 didn't
dramatically affect test behavior. It doesn't necessarily indicate a problem,
but we need to add many new tests for cross-origin WebSocket usage to check
that it functions correctly.

Per-function comments in WebCore/ChangeLog would be appreciated. The change to
KURL::query() is particularly interesting, as someone working on bug 21015 will
need to know the rationale of the change you're making here, and won't find it.


More information about the webkit-reviews mailing list