[webkit-reviews] review granted: [Bug 32024] [GTK] WebKit does not compile without JAVASCRIPT_DEBUGGER : [Attachment 44085] patch for the build error when JAVASCRIPT_DEBUGGER is disabled on gtk

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue Dec 1 17:08:31 PST 2009


Eric Seidel <eric at webkit.org> has granted Gyuyoung Kim <gyuyoung at gmail.com>'s
request for review:
Bug 32024: [GTK] WebKit does not compile without JAVASCRIPT_DEBUGGER
https://bugs.webkit.org/show_bug.cgi?id=32024

Attachment 44085: patch for the build error when JAVASCRIPT_DEBUGGER is
disabled on gtk
https://bugs.webkit.org/attachment.cgi?id=44085&action=review

------- Additional Comments from Eric Seidel <eric at webkit.org>
I'm surprised that these case statements would be outisde the #if.  Does the UI
still show JS profiling stuff, and does the console object still expose
profiling JS commands?

This looks OK as a build fix, but is probably not the full fix.


More information about the webkit-reviews mailing list