[webkit-reviews] review denied: [Bug 32031] Tag purgeable buffers for identification by vmmap tool : [Attachment 44096] patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue Dec 1 14:12:05 PST 2009


Mark Rowe (bdash) <mrowe at apple.com> has denied Jens Alfke <snej at chromium.org>'s
request for review:
Bug 32031: Tag purgeable buffers for identification by vmmap tool
https://bugs.webkit.org/show_bug.cgi?id=32031

Attachment 44096: patch
https://bugs.webkit.org/attachment.cgi?id=44096&action=review

------- Additional Comments from Mark Rowe (bdash) <mrowe at apple.com>
254 is within the range of tags reserved for applications so it is not suitable
for use by WebKit.  We should obtain a tag within the range allocated to
libraries and make use of that.  This should also be handled in a manner
consistent with the other locations that we tag allocations.  See VMTags.h in
WTF for details.


More information about the webkit-reviews mailing list