[webkit-reviews] review denied: [Bug 32012] JavaScript delete operator returns true for string properties : [Attachment 44062] Proposed patch and test

[bugzilla-daemon at webkit.org]

Darin Adler <darin at apple.com> has denied Kent Hansen <kent.hansen at nokia.com>'s
request for review:
Bug 32012: JavaScript delete operator returns true for string properties
https://bugs.webkit.org/show_bug.cgi?id=32012

Attachment 44062: Proposed patch and test
https://bugs.webkit.org/attachment.cgi?id=44062&action=review

------- Additional Comments from Darin Adler <darin at apple.com>
Thanks for tackling this! This is almost right, but not quite.

> +    bool isStrictUInt32;
> +    unsigned i = propertyName.toStrictUInt32(&isStrictUInt32);
> +    if (isStrictUInt32 && internalValue()->canGetIndex(i))
> +	   return false;

This code needs to use toArrayIndex rather than toStrictUInt32. These functions
differ in how they handle the value 4294967295. And you should make sure there
is a test case for that particular number and other numbers just higher and
lower than that.

review-