[webkit-reviews] review denied: [Bug 31617] WebSocket handshake doesn't check query component of URL : [Attachment 44052] WebSocket handshake check query component of URL

[bugzilla-daemon at webkit.org]

Alexey Proskuryakov <ap at webkit.org> has denied Fumitoshi Ukai
<ukai at chromium.org>'s request for review:
Bug 31617: WebSocket handshake doesn't check query component of URL
https://bugs.webkit.org/show_bug.cgi?id=31617

Attachment 44052: WebSocket handshake check query component of URL
https://bugs.webkit.org/attachment.cgi?id=44052&action=review

------- Additional Comments from Alexey Proskuryakov <ap at webkit.org>
+# Missing "WebSocket is closed"

I don't think this is still needed - bug 31659	 is fixed now.

+var url = "ws://user:pass@localhost:8880/websocket/tests/echo-location";

Are you testing cross-origin WebSocket here? HTTP tests run from 127.0.0.1, not
from localhost, so accessing localhost is cross origin. Are WebSocket tests
different?

+String KURL::resourceName() const

Now that I see where "resource name" is defined, I'm positive that this
accessor shouldn't be added to KURL. Resource name is solely a Web Sockets
concept, so it should be confined to Web Sockets code.