[webkit-reviews] review denied: [Bug 30778] GraphicsContext3D should be using fastMalloc : [Attachment 44074] Patch with updated test case

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue Dec 1 07:47:18 PST 2009


Adam Roben (aroben) <aroben at apple.com> has denied Chris Marrin
<cmarrin at apple.com>'s request for review:
Bug 30778: GraphicsContext3D should be using fastMalloc
https://bugs.webkit.org/show_bug.cgi?id=30778

Attachment 44074: Patch with updated test case
https://bugs.webkit.org/attachment.cgi?id=44074&action=review

------- Additional Comments from Adam Roben (aroben) <aroben at apple.com>
> -    GLchar* info = (GLchar*) malloc(length);
> +    GLchar* info = (GLchar*) fastMalloc(length);
> +    if (!info)
> +	   return "";
> +
>      ::glGetProgramInfoLog((GLuint) program->object(), length, &size, info);
>      String s(info);
>      free(info);

If you use fastMalloc, you need to use fastFree, too.


More information about the webkit-reviews mailing list