[webkit-reviews] review requested: [Bug 30206] Geolocation lacks V8 bindings : [Attachment 44067] Patch 3 for Bug 30206

[bugzilla-daemon at webkit.org]

Steve Block <steveblock at google.com> has asked  for review:
Bug 30206: Geolocation lacks V8 bindings
https://bugs.webkit.org/show_bug.cgi?id=30206

Attachment 44067: Patch 3 for Bug 30206
https://bugs.webkit.org/attachment.cgi?id=44067&action=review

------- Additional Comments from Steve Block <steveblock at google.com>
> Yeah, what the style-elf said.
Fixed. The script still reports a couple of errors regarding include order,
because V8GeolocationCustom and V8CoordinatesCustom don't have a 'primary
header' that follows the standard naming pattern.

> BTW, do we need compile guards around geolocation?
No, the decision taken for Geolocation was to not guard the (majority of the)
code with enable flags, so as to make sure it's always built and doesn't rot
(See Bug 25756). The guards are used only in Navigator.idl (to conditionally
expose the JS geolocation object) and in GeolocationService.cpp (to satisfy the
linker on platforms that don't implement GeolocationService).