[webkit-reviews] review requested: [Bug 28047] add utility method to enable logging messages for inspector development : [Attachment 38841] proposed patch - 2009/08/31

[bugzilla-daemon at webkit.org]

Patrick Mueller <pmuellr at yahoo.com> has asked  for review:
Bug 28047: add utility method to enable logging messages for inspector
development
https://bugs.webkit.org/show_bug.cgi?id=28047

Attachment 38841: proposed patch - 2009/08/31
https://bugs.webkit.org/attachment.cgi?id=38841&action=review

------- Additional Comments from Patrick Mueller <pmuellr at yahoo.com>
Per previous review, updated WebCore/page/Console.h with the new level.  Also
added corresponding change in the .cpp file (to print the level name).

I also attempted to get the "repeatCount" bit right with the message.  As it
is, if you repeat a message, as in the supplied manual test case, you get
neither a new message nor a repeat count badge.  I'm going to chalk this up to
wonkiness introduced by bug 28856, but I don't think the bad behaviour is a
show-stopper, since the new behaviour is only relevant to WebKit developers.

I've tested the repeatCount code by manually maintaining a repeatCount myself,
just to make sure the CSS bits work, and they do.  What I don't know is if I
have to actually maintain the repeatCount, or if the ConsoleView.addMessage()
is supposed to be doing that for me.  Looks like the latter.