[webkit-reviews] review requested: [Bug 28225] check-webkit-style uses python from /usr/bin instead of the PATH : [Attachment 38831] This is the second patch attempt for this problem

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Mon Aug 31 13:28:23 PDT 2009


Carol Szabo <carol.szabo at nokia.com> has asked  for review:
Bug 28225: check-webkit-style uses python from /usr/bin instead of the PATH
https://bugs.webkit.org/show_bug.cgi?id=28225

Attachment 38831: This is the second patch attempt for this problem
https://bugs.webkit.org/attachment.cgi?id=38831&action=review

------- Additional Comments from Carol Szabo <carol.szabo at nokia.com>
I have applied the fix to all python scripts per lgombos's comments.
I was reluctant to fix all scripts in the directory as I am not familiar with
many of them and I think that it is preferable that (as the case of style
errors in C/C++ code) they are fixed as they cause problems.
I am not quite an "if its not broken don't fix it" kind of guy, but I am
reluctant to take poorly understood (at least by me) risks when the benefit is
small.


More information about the webkit-reviews mailing list