[webkit-reviews] review requested: [Bug 22920] Inspector Request Headers Should Show Data/Variables/Parameters Sent With Request : [Attachment 38829] proposed patch - 2009/08/31

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Mon Aug 31 12:14:32 PDT 2009

Patrick Mueller <pmuellr at yahoo.com> has asked  for review:
Bug 22920: Inspector Request Headers Should Show Data/Variables/Parameters Sent
With Request

Attachment 38829: proposed patch - 2009/08/31

------- Additional Comments from Patrick Mueller <pmuellr at yahoo.com>
All of the issues from the previous review have been attended to, except for
the first:

in WebCore/inspector/front-end/Resource.js:
> +    this.requestMethod = requestMethod || "";
> +    this.requestFormData = requestFormData || "";

> Is this needed, can they be null/undefined?

It's not clear to me that they will always be string values, they might be null
at some point along the way.  Code further down in the processing expects these
to be string values, so seems best to initialize them to an empty string here. 
Empty string turns out to be a good default value for both of these.

Regarding the encoded/decoded versions of the form data; the initial display is
now decoded.  A hover help over a form data item displays: "Double-Click to
toggle between URL encoded and decoded formats".  Double-clicking results in
toggling between encoded and decoded.  Initially I was thinking of doing this
with a single click, but realized (without trying it), that this would likely
interfere with trying to select the items if you wanted to copy them to the

More information about the webkit-reviews mailing list