[webkit-reviews] review granted: [Bug 28795] fast/workers/worker-lifecycle.html crashes intermittently on snowleopard : [Attachment 38770] patch with fix for typo in comment

[bugzilla-daemon at webkit.org]

Alexey Proskuryakov <ap at webkit.org> has granted Andrew Wilson
<atwilson at chromium.org>'s request for review:
Bug 28795: fast/workers/worker-lifecycle.html crashes intermittently on
snowleopard
https://bugs.webkit.org/show_bug.cgi?id=28795

Attachment 38770: patch with fix for typo in comment
https://bugs.webkit.org/attachment.cgi?id=38770&action=review

------- Additional Comments from Alexey Proskuryakov <ap at webkit.org>
+	 Error events should still be delivered even if the worker thread is
closing.

This sounds like something worth a comment in code, ideally with an explanation
of why they should be delivered. Is this something covered by existing tests?

+	 Also fixed problem where error events were not dispatched if error
handlers were added via addEventListener().

Please add a test for this bug fix.

 void SharedWorkerProxy::close()
 {
-    ASSERT(!isClosing());

So, this function can now be called repeatedly. Is it OK to call
m_thread->stop() twice?

r=me on a condition there's a good answer to this last question.