[webkit-reviews] review denied: [Bug 28696] Middle click doesn't trigger onpaste event in Chromium : [Attachment 38515] Handle middle click in Chromium like QT

[bugzilla-daemon at webkit.org]

Eric Seidel <eric at webkit.org> has denied Steve VanDeBogart
<vandebo-webkitbugzilla at nerdbox.net>'s request for review:
Bug 28696: Middle click doesn't trigger onpaste event in Chromium
https://bugs.webkit.org/show_bug.cgi?id=28696

Attachment 38515: Handle middle click in Chromium like QT
https://bugs.webkit.org/attachment.cgi?id=38515&action=review

------- Additional Comments from Eric Seidel <eric at webkit.org>
This needs a layout test.

Also, funny spacing in the ChangeLog:
+	 Handle middle click in Chromium like QT
+
+	 https://bugs.webkit.org/show_bug.cgi?id=28696

Seems wrong:
+#if PLATFORM(QT) || PLATFORM(CHROMIUM)
     bool isSelectionMode() const;
     void setSelectionMode(bool selectionMode);
 #endif

You only want this on Chromium Linux, or?

Enums are almost always clearer than bools:
+	 static bool
clipboardIsFormatAvailable(PasteboardPrivate::ClipboardFormat, bool);