[webkit-reviews] review granted: [Bug 28742] [Chromium] Combining Diacritical Marks (U+0300..) are not handled correctly : [Attachment 38713] patch v3

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Mon Aug 31 03:42:56 PDT 2009


Eric Seidel <eric at webkit.org> has granted Yusuke Sato <yusukes at chromium.org>'s
request for review:
Bug 28742: [Chromium] Combining Diacritical Marks (U+0300..) are not handled
correctly
https://bugs.webkit.org/show_bug.cgi?id=28742

Attachment 38713: patch v3
https://bugs.webkit.org/attachment.cgi?id=38713&action=review

------- Additional Comments from Eric Seidel <eric at webkit.org>
Looks good.

For the future, no { } around single line ifs:
	     if (block == UBLOCK_COMBINING_DIACRITICAL_MARKS) {
 307		     return getNormalizedTextRun(originalRun);
 308		 }


More information about the webkit-reviews mailing list