[webkit-reviews] review denied: [Bug 28835] [Haiku] Correction of native image creating. : [Attachment 38792] Patch v1

[bugzilla-daemon at webkit.org]

Eric Seidel <eric at webkit.org> has denied Maxime Simon
<simon.maxime at gmail.com>'s request for review:
Bug 28835: [Haiku] Correction of native image creating.
https://bugs.webkit.org/show_bug.cgi?id=28835

Attachment 38792: Patch v1
https://bugs.webkit.org/attachment.cgi?id=38792&action=review

------- Additional Comments from Eric Seidel <eric at webkit.org>
The ChangeLog really needs a clearer description of why you're doing this.  The
code might benefit from similar comments.

I would probably have pre-computed the source and dest into nicely named locals
first:
	 memcpy(static_cast<uint8*>(bmp->Bits()) + y * bmp->BytesPerRow(),
 42		   reinterpret_cast<const uint8*>(m_bytes.data()) + y *
bytesPerRow, minBytesPerRow);

r- for an unclear ChangeLog.

How is the B_RGBA32 storage different from WebCore's?  Should we be using some
sort of COMPILE_ASSERTs here to verify the current assumptions?