[webkit-reviews] review denied: [Bug 28750] Add a Linux and Mac SQLite VFS for Chromium : [Attachment 38640] patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Fri Aug 28 12:34:52 PDT 2009

Dimitri Glazkov (Google) <dglazkov at chromium.org> has denied Dumitru Daniliuc
<dumi at chromium.org>'s request for review:
Bug 28750: Add a Linux and Mac SQLite VFS for Chromium

Attachment 38640: patch

------- Additional Comments from Dimitri Glazkov (Google)
<dglazkov at chromium.org>
> -    // open databases using Chromium's VFS
> +    // open databases using the default VFS
> +    // in renderers, it should be Chromium's VFS; in the browser process it
should be SQLite's default VFS
>      return sqlite3_open_v2(fileName.utf8().data(), database,
> -			      "chromium_vfs");
> +			      NULL);
0 is WebKit style.

Otherwise, LGTM.

More information about the webkit-reviews mailing list