[webkit-reviews] review granted: [Bug 28792] update-webkit-localizable-strings script can no longer complete : [Attachment 38719] patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Fri Aug 28 07:53:53 PDT 2009


Darin Adler <darin at apple.com> has granted chris fleizach
<cfleizach at apple.com>'s request for review:
Bug 28792: update-webkit-localizable-strings script can no longer complete
https://bugs.webkit.org/show_bug.cgi?id=28792

Attachment 38719: patch
https://bugs.webkit.org/attachment.cgi?id=38719&action=review

------- Additional Comments from Darin Adler <darin at apple.com>
It seems very strange to me to use these computer style strings like
ARIAApplicationLog as the group text, and yet ask localizers to translate them.


I'm going to say r=me, because the change seems fine mechanically, but I think
you should discuss this with other architects of the VoiceOver application and
localization of terms used by it. I am surprised that it's a good idea to
include the word "ARIA" in the terms that are spoken aloud.


More information about the webkit-reviews mailing list