[webkit-reviews] review granted: [Bug 25889] [GTK] scrollbar policy for main frame is not implementable : [Attachment 38691] report scrollbar policy

[bugzilla-daemon at webkit.org]

Holger Freyther <zecke at selfish.org> has granted Gustavo Noronha (kov)
<gns at gnome.org>'s request for review:
Bug 25889: [GTK] scrollbar policy for main frame is not implementable
https://bugs.webkit.org/show_bug.cgi?id=25889

Attachment 38691: report scrollbar policy
https://bugs.webkit.org/attachment.cgi?id=38691&action=review

------- Additional Comments from Holger Freyther <zecke at selfish.org>

>  
> +void ScrollView::setScrollbarModes(ScrollbarMode horizontalMode,
ScrollbarMode verticalMode)
> +{
> +    if (horizontalMode == m_horizontalScrollbarMode && verticalMode ==
m_verticalScrollbarMode)
> +	   return;
> +
> +    m_horizontalScrollbarMode = horizontalMode;
> +    m_verticalScrollbarMode = verticalMode;
> +
> +    // We don't really care about reporting policy changes on frames
> +    // that have no adjustments attached to them.
> +    if (!m_horizontalAdjustment) {
> +	   updateScrollbars(scrollOffset());
> +	   return;
> +    }
> +
> +    if (!isFrameView())
> +	   return;

okay, I don't think we need this here, but it does not really hurt. Thanks a
lot for finishing it.