[webkit-reviews] review requested: [Bug 28808] [Skia] Fix flaky layout test svg/dynamic-updates/SVGClipPathElement-dom-clipPathUnits-attr.html [DEBUG] : [Attachment 38733] patch: check skia safety of path on conversion to local coordinates

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Fri Aug 28 07:20:01 PDT 2009


Roland Steiner <rolandsteiner at google.com> has asked  for review:
Bug 28808: [Skia] Fix flaky layout test
svg/dynamic-updates/SVGClipPathElement-dom-clipPathUnits-attr.html [DEBUG]
https://bugs.webkit.org/show_bug.cgi?id=28808

Attachment 38733: patch: check skia safety of path on conversion to local
coordinates
https://bugs.webkit.org/attachment.cgi?id=38733&action=review

------- Additional Comments from Roland Steiner <rolandsteiner at google.com>

The patch adds an explicit check for the validity of the path when it is
transformed into local coordinates. 

This was the most suitable place I could find that didn't cause an inordinate
amount of refactoring. Also, it seems pertinent and may also catch other cases
that are not limited to clipping paths.


More information about the webkit-reviews mailing list