[webkit-reviews] review granted: [Bug 24758] [Gtk] Implement a WebDataSource for the gtk port : [Attachment 38720] Update web resource patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Fri Aug 28 06:36:19 PDT 2009


Gustavo Noronha (kov) <gns at gnome.org> has granted Jan Alonzo
<jmalonzo at gmail.com>'s request for review:
Bug 24758: [Gtk] Implement a WebDataSource for the gtk port
https://bugs.webkit.org/show_bug.cgi?id=24758

Attachment 38720: Update web resource patch
https://bugs.webkit.org/attachment.cgi?id=38720&action=review

------- Additional Comments from Gustavo Noronha (kov) <gns at gnome.org>
> +					      const gchar* frameName)
> +{
> +    ASSERT(data);
> +    ASSERT(uri);
> +    ASSERT(mime_type);

+1 for Xan's comments; also notice that this check would only have any effect
in debug builds, and we do want checks in runtime for release builds =).


More information about the webkit-reviews mailing list