[webkit-reviews] review granted: [Bug 28667] Make XSSAuditor go fast : [Attachment 38454] Patch v1

[bugzilla-daemon at webkit.org]

Eric Seidel <eric at webkit.org> has granted Adam Barth <abarth at webkit.org>'s
request for review:
Bug 28667: Make XSSAuditor go fast
https://bugs.webkit.org/show_bug.cgi?id=28667

Attachment 38454: Patch v1
https://bugs.webkit.org/attachment.cgi?id=38454&action=review

------- Additional Comments from Eric Seidel <eric at webkit.org>
LGTM.

I've got 2 nits though:

1. You mentioned that this is not technically "memoization" but rather caching.
 If so, let's call it CachingURLCanonicalizer and m_cachedURL (and maybe
m_inputURL?)

2.  seems strange to change some decodeHTMLentities to decodeEntities and
others to decodeHTMLEntities.  Pick one. :)  I suggest "decodeEntities".

I don't need to see this again.