[webkit-reviews] review denied: [Bug 9589] WCSS: -wap-accesskey not supported : [Attachment 34971] patch that fixes the comments by the reviewer

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu Aug 27 16:26:48 PDT 2009

Eric Seidel <eric at webkit.org> has denied Charles Wei
<charles.wei at torchmobile.com.cn>'s request for review:
Bug 9589: WCSS: -wap-accesskey not supported

Attachment 34971: patch that fixes the comments by the reviewer

------- Additional Comments from Eric Seidel <eric at webkit.org>
+Element* Document::getElementByAccessKey(const String& key) const

seems like a really slow way to crawl through the DOM for the access keys.  Why
can't one expand the m_elementsByAccessKey strategy?  querySelector would
answer the CSS side of the question.

+	 if (accessKeys.contains(key)) {
+	     return element;
+	 }

+	 //2, Try to get accecckeys from internal WCSS and external WCSS in

+	 String accessKeys ; //accesskeysForElement(element, m_styleSelector);

Honestly I don't really want this change.  I still don't understand why this
obscure part of a dying spec is needed, and clearly no other reviewer seems to
care enough to review it either since this bug has been ignored for over 7
months in the queue.

r- for the nits above.

More information about the webkit-reviews mailing list