[webkit-reviews] review denied: [Bug 28742] [Chromium] Combining Diacritical Marks (U+0300..) are not handled correctly : [Attachment 38623] patch v2

[bugzilla-daemon at webkit.org]

Eric Seidel <eric at webkit.org> has denied Yusuke Sato <yusukes at chromium.org>'s
request for review:
Bug 28742: [Chromium] Combining Diacritical Marks (U+0300..) are not handled
correctly
https://bugs.webkit.org/show_bug.cgi?id=28742

Attachment 38623: patch v2
https://bugs.webkit.org/attachment.cgi?id=38623&action=review

------- Additional Comments from Eric Seidel <eric at webkit.org>
Two nits:

We can get rid of the delete() code by using:
OwnPtr<TextRun> m_normalizedRun;
OwnArrayPtr<UChar> m_normalizedBuffer;

Then you just set m_run = m_normalizedRun.get();

In fact, then it still could be a const TextRun&, it doesn't need to change to
be a pointer (although it can be made one if you feel that's cleaner).

This should use early return:
316	    if (U_SUCCESS(error)) {

if (U_FAILURE(error))
     return;