[webkit-reviews] review denied: [Bug 28769] The type of HTMLInputElement::list should follow the standard : [Attachment 38664] Proposed patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu Aug 27 10:40:07 PDT 2009


Eric Seidel <eric at webkit.org> has denied TAMURA, Kent <tkent at chromium.org>'s
request for review:
Bug 28769: The type of HTMLInputElement::list should follow the standard
https://bugs.webkit.org/show_bug.cgi?id=28769

Attachment 38664: Proposed patch
https://bugs.webkit.org/attachment.cgi?id=38664&action=review

------- Additional Comments from Eric Seidel <eric at webkit.org>
I agree with Darin.  This "bug" occurred because I asked Kent in original
review comments to change the type from HTMLElement* to HTMLDataListElement* to
make internal clients easier.  I don't really care one way or the other re: the
idl, but if we'd like to be sure to match the spec exactly, that's fine too.

Basically, keep the idl change, revert the rest would be my recommendation.


More information about the webkit-reviews mailing list