[webkit-reviews] review denied: [Bug 28740] Factor out summary bar from Resources panel to reuse it in Heap profile view : [Attachment 38614] Proposed patch
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Thu Aug 27 08:38:31 PDT 2009
Timothy Hatcher <timothy at hatcher.name> has denied Mikhail Naganov
<mnaganov at chromium.org>'s request for review:
Bug 28740: Factor out summary bar from Resources panel to reuse it in Heap
profile view
https://bugs.webkit.org/show_bug.cgi?id=28740
Attachment 38614: Proposed patch
https://bugs.webkit.org/attachment.cgi?id=38614&action=review
------- Additional Comments from Timothy Hatcher <timothy at hatcher.name>
> + return this.calculator_;
> + this.calculator_ = x;
Our coding style uses prefix underscores for private members/functions.
Looks good otherwise.
More information about the webkit-reviews
mailing list