[webkit-reviews] review denied: [Bug 28040] commit-queue needs a master process : [Attachment 38637] Patch v1

[bugzilla-daemon at webkit.org]

Adam Barth <abarth at webkit.org> has denied Eric Seidel <eric at webkit.org>'s
request for review:
Bug 28040: commit-queue needs a master process
https://bugs.webkit.org/show_bug.cgi?id=28040

Attachment 38637: Patch v1
https://bugs.webkit.org/attachment.cgi?id=38637&action=review

------- Additional Comments from Adam Barth <abarth at webkit.org>
+	     self._run_command(['bugzilla-tool', 'land-patches',
'--force-clean', '--commit-queue', '--quiet', bug_id])

This seems to require bugzilla-tool to be in your path.  We should use our get
webkit script path routine here.

+	     bug_id = bug_ids[0]

I'm worried we could get stuck in a loop processing bug zero.  Can't we
restructure this loop so we go through all the bugs in the queue?  Also, we
should put everything in the try-catch to avoid dieing on exceptions.