[webkit-reviews] review canceled: [Bug 28675] Make prepare-ChangeLog notice property changes : [Attachment 38604] Make prepare-ChangeLog work as described, v2

[bugzilla-daemon at webkit.org]

Cameron McCormack <cam at mcc.id.au> has canceled Cameron McCormack
<cam at mcc.id.au>'s request for review:
Bug 28675: Make prepare-ChangeLog notice property changes
https://bugs.webkit.org/show_bug.cgi?id=28675

Attachment 38604: Make prepare-ChangeLog work as described, v2
https://bugs.webkit.org/attachment.cgi?id=38604&action=review

------- Additional Comments from Cameron McCormack <cam at mcc.id.au>
(In reply to comment #6)
> Hmm...I think it would be nice to list all property changes regardless of
other
> changes to the file.	When a new file is added, I think the main entry for
the
> file says "Added.", but all the new methods are also listed.	We could do
> something similar for properties.

I've made it always list the property changes if that information is available.
 I don't think adding a separate line for each property changed is really
necessary, since often it will be clear what the property change is doing. 
(For example adding svn:executable really only means one thing.)

I've added some code to notice which properties have been added/deleted when
doing an 'svn mv' now, too.

For example, after doing:

  $ svn mv ChangeLog-2009-06-16 ChangeLog-Old
  $ svn propset svn:executable . ChangeLog-Old
  $ touch NewFile
  $ svn add NewFile
  $ svn propset blah . NewFile
  $ svn propset myprop . Scripts/build-webkit
  $ svn propdel svn:executable Scripts/build-webkit

the ChangeLog output is:

	* ChangeLog-2009-06-16: Removed.
	* ChangeLog-Old: Copied from ChangeLog-2009-06-16. Added property
svn:executable.
	* NewFile: Added with property blah.
	* Scripts/build-webkit: Added property myprop. Removed property
svn:executable.

> Ultimately, the patch author has the responsibility to update the ChangeLog
> entry, so I think it's best to give them all the information possible (as
long
> as the default behavior can also be used without modification).

OK.  Is there a need for me to wrap the generated lines?