[webkit-reviews] review denied: [Bug 28707] [Chromium] Complex text doesn't show up with text stroking : [Attachment 38600] complex_text_second_fix_v1

[bugzilla-daemon at webkit.org]

Darin Fisher (:fishd, Google) <fishd at chromium.org> has denied Yusuke Sato
<yusukes at chromium.org>'s request for review:
Bug 28707: [Chromium] Complex text doesn't show up with text stroking
https://bugs.webkit.org/show_bug.cgi?id=28707

Attachment 38600: complex_text_second_fix_v1
https://bugs.webkit.org/attachment.cgi?id=38600&action=review

------- Additional Comments from Darin Fisher (:fishd, Google)
<fishd at chromium.org>
> +2009-08-25  Yusuke Sato  <yusukes at chromium.org>
...
> +	   Added extra NULL checks for HDC. This is the second fix for issue
28707,
> +	and the fix is similar to http://trac.webkit.org/changeset/45482.

nit: please do not include tabs in the ChangeLog.  R- for this reason.


> +++ b/WebCore/platform/graphics/chromium/UniscribeHelper.cpp

> +	       if (dc) {
> +		   if (firstRun) {
> +		       oldFont = SelectObject(dc, shaping.m_hfont);
> +		       firstRun = false;
> +		   } else
> +		       SelectObject(dc, shaping.m_hfont);
> +	       }

This is OK, but maybe it should use the useWindowsDrawing local variable
instead just as the code within the for loop does.  What do you think?

-Darin