[webkit-reviews] review granted: [Bug 28720] [V8] Fix Canvas layout test failures in Chromium build. : [Attachment 38571] Proposed Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue Aug 25 15:32:06 PDT 2009


David Levin <levin at chromium.org> has granted Jian Li <jianli at chromium.org>'s
request for review:
Bug 28720: [V8] Fix Canvas layout test failures in Chromium build.
https://bugs.webkit.org/show_bug.cgi?id=28720

Attachment 38571: Proposed Patch
https://bugs.webkit.org/attachment.cgi?id=38571&action=review

------- Additional Comments from David Levin <levin at chromium.org>

> diff --git a/WebCore/bindings/v8/custom/V8DocumentCustom.cpp
b/WebCore/bindings/v8/custom/V8DocumentCustom.cpp
> +	   ASSERT(false);

Use ASSERT_NOT_REACHED();

>  } // namespace WebCore
> diff --git a/WebCore/bindings/v8/custom/V8HTMLCanvasElementCustom.cpp
b/WebCore/bindings/v8/custom/V8HTMLCanvasElementCustom.cpp
> +	   ASSERT(false);

Use ASSERT_NOT_REACHED();


More information about the webkit-reviews mailing list