[webkit-reviews] review denied: [Bug 28131] [Haiku] Adding font-specific files to WebCore. : [Attachment 38545] Adding four font-specific files to WebCore.

[bugzilla-daemon at webkit.org]

Oliver Hunt <oliver at apple.com> has denied Maxime Simon
<simon.maxime at gmail.com>'s request for review:
Bug 28131: [Haiku] Adding font-specific files to WebCore.
https://bugs.webkit.org/show_bug.cgi?id=28131

Attachment 38545: Adding four font-specific files to WebCore.
https://bugs.webkit.org/attachment.cgi?id=38545&action=review

------- Additional Comments from Oliver Hunt <oliver at apple.com>

> +    font_family* fontFamily =
static_cast<font_family*>(malloc(sizeof(font_family)));
> +    findMatchingFontFamily(familyName, fontFamily);

You are leaking the fontFamily allocation, this should be done as
> +    font_family fontFamily;
> +    findMatchingFontFamily(familyName, &fontFamily);