[webkit-reviews] review requested: [Bug 27099] Elements with display none still gets focus and take part in the tab order : [Attachment 38561] Handle the basic hidden case in Node::isFocusable

[bugzilla-daemon at webkit.org]

Erik Arvidsson <arv at chromium.org> has asked  for review:
Bug 27099: Elements with display none still gets focus and take part in the tab
order
https://bugs.webkit.org/show_bug.cgi?id=27099

Attachment 38561: Handle the basic hidden case in Node::isFocusable
https://bugs.webkit.org/attachment.cgi?id=38561&action=review

------- Additional Comments from Erik Arvidsson <arv at chromium.org>
This cleans up the mess of supportsFocus and isFocusable. supportsFocus now
means that the node should support focus if layout is ignored. For example a
link should support focus and a span with tabIndex >= 0 and a contentEditabl
element as well. isFocusable checks that the element has a renderer and that it
is visible. Some derived classes of Node also check that the box for the
element is non empty (but I didn't change those cases since there were rdar
bugs for those).