[webkit-reviews] review denied: [Bug 27457] Add <input type=email> validation support : [Attachment 38487] Patch v1, Changelogs were missing

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue Aug 25 10:43:17 PDT 2009


Eric Seidel <eric at webkit.org> has denied Michelangelo De Simone
<micdesim at gmail.com>'s request for review:
Bug 27457: Add <input type=email> validation support
https://bugs.webkit.org/show_bug.cgi?id=27457

Attachment 38487: Patch v1, Changelogs were missing
https://bugs.webkit.org/attachment.cgi?id=38487&action=review

------- Additional Comments from Eric Seidel <eric at webkit.org>
Maybe we could also break:
 31 #define RFC5322_DOTATOMTEXT
"[a-z0-9!#$%&'*+/=?^_`{|}~-]+(?:\\.[a-z0-9!#$%&'*+/=?^_`{|}~-]+)*"

up into parts.	It's kinda confusing to read as-is.

r- for the tests being confusing.


More information about the webkit-reviews mailing list