[webkit-reviews] review denied: [Bug 28131] [Haiku] Adding font-specific files to WebCore. : [Attachment 38538] Adding four font-specific files to WebCore.

[bugzilla-daemon at webkit.org]

Oliver Hunt <oliver at apple.com> has denied Maxime Simon
<simon.maxime at gmail.com>'s request for review:
Bug 28131: [Haiku] Adding font-specific files to WebCore.
https://bugs.webkit.org/show_bug.cgi?id=28131

Attachment 38538: Adding four font-specific files to WebCore.
https://bugs.webkit.org/attachment.cgi?id=38538&action=review

------- Additional Comments from Oliver Hunt <oliver at apple.com>
For the sake of those of us who aren't familiar with haiku, make the
font_family argument to findMatchingFontFamily a pointer, and dereference
appropriately.	Also replace all uses of strcpy with strncpy (never use strcpy
-- most modern analysis tools will flag any use of strcpy as being bad).

I don't know haiku idioms but
m_font->SetFamilyAndStyle(fontFamily, 0);
seems superfluous as it's immediately followed by
m_font->SetFamilyAndStyle(fontFamily, *fontStyle);

Fix those up and it will be good.