[webkit-reviews] review granted: [Bug 28670] [Chromium] Multi-value select boxes cannot do non-contiguous selection : [Attachment 38478] Adjusted condition per comment 6

[bugzilla-daemon at webkit.org]

Mark Rowe (bdash) <mrowe at apple.com> has granted Jeremy Moskovich
<playmobil at google.com>'s request for review:
Bug 28670: [Chromium] Multi-value select boxes cannot do non-contiguous
selection
https://bugs.webkit.org/show_bug.cgi?id=28670

Attachment 38478: Adjusted condition per comment 6
https://bugs.webkit.org/attachment.cgi?id=38478&action=review

------- Additional Comments from Mark Rowe (bdash) <mrowe at apple.com>
> Index: WebCore/ChangeLog
> ===================================================================
> --- WebCore/ChangeLog (revision 47695)
> +++ WebCore/ChangeLog (working copy)
> @@ -1,3 +1,20 @@
> +2009-08-23  Robert Sesek  <rsesek at chromium.org>
> +
> +	   Reviewed by NOBODY (OOPS!).
> +
> +	   [Chromium] Multi-value select boxes cannot do non-contiguous
selection on Mac
> +	   https://bugs.webkit.org/show_bug.cgi?id=28670
> +
> +	   Change the condition regarding the key modifier check for
non-contiguous
> +	   selection on a multi-value select from PLATFORM(MAC) to
PLATFORM(DARWIN), so
> +	   that Chromium works as expected on Mac.

This doesn't describe the change that was actually made, so it'll need to be
updated. The actual code change looks fine.

r=me