[webkit-reviews] review denied: [Bug 5863] feMorphology filter is not implemented : [Attachment 38470] feMorphologyElement

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Mon Aug 24 13:42:53 PDT 2009


Eric Seidel <eric at webkit.org> has denied Dirk Schulze <krit at webkit.org>'s
request for review:
Bug 5863: feMorphology filter is not implemented
https://bugs.webkit.org/show_bug.cgi?id=5863

Attachment 38470: feMorphologyElement
https://bugs.webkit.org/attachment.cgi?id=38470&action=review

------- Additional Comments from Eric Seidel <eric at webkit.org>
I don't understand why these exist:
char SVGRadiusXAttrIdentifier[] = "SVGRadiusXAttr";
 33 char SVGRadiusYAttrIdentifier[] = "SVGRadiusYAttr";

Why the _?
set_operatorBaseValue
is this all to avoid "operator" in C++?

This seems wrong, no?
 36	    readonly attribute SVGAnimatedEnumeration _operator;


More information about the webkit-reviews mailing list