[webkit-reviews] review denied: [Bug 28681] Element::recalcStyle() accesses freed RenderStyles (fast/css/rem-dynamic-scaling.html) : [Attachment 38495] patch
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Mon Aug 24 13:25:59 PDT 2009
Darin Adler <darin at apple.com> has denied Nate Chapin <japhet at chromium.org>'s
request for review:
Bug 28681: Element::recalcStyle() accesses freed RenderStyles
(fast/css/rem-dynamic-scaling.html)
https://bugs.webkit.org/show_bug.cgi?id=28681
Attachment 38495: patch
https://bugs.webkit.org/attachment.cgi?id=38495&action=review
------- Additional Comments from Darin Adler <darin at apple.com>
Since currentStyle is already a local variable, it's much cleaner to just
change its type to a RefPtr instead of using the protect idiom.
Please do that.
More information about the webkit-reviews
mailing list