[webkit-reviews] review granted: [Bug 28659] We could use a stale frame size when going back to a cached page : [Attachment 38488] Add layout test

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Mon Aug 24 12:00:52 PDT 2009


Brady Eidson <beidson at apple.com> has granted Ada Chan <adachan at apple.com>'s
request for review:
Bug 28659: We could use a stale frame size when going back to a cached page
https://bugs.webkit.org/show_bug.cgi?id=28659

Attachment 38488: Add layout test
https://bugs.webkit.org/attachment.cgi?id=38488&action=review

------- Additional Comments from Brady Eidson <beidson at apple.com>
> Index: LayoutTests/loader/go-back-to-different-window-size.html
> ===================================================================
> --- LayoutTests/loader/go-back-to-different-window-size.html	(revision 0)
> +++ LayoutTests/loader/go-back-to-different-window-size.html	(revision 0)
> @@ -0,0 +1,44 @@
> +<html>
> +<script>
> +
> +// Navigation steps:
> +// 1- loads this page
> +// 2- resizes the window to (300, 300)
> +// 2- loads this page + hash
> +// 3- loads a data URL that resizes the window to (1000, 1000) and navigates
back
> +// 4- loads this page + hash and checks the window width to make sure it's >
300

I think this comment is out of date, and refers to an earlier version of the
patch.

> +    // We don't need to depend on this long timer when pageshow event is
implemented for b/f cache (<rdar://problem/6440869>).

Could you file a bug to update this test once we've implemented pageshow, and
block that bug on the implementing pageshow bug?

> +    window.setTimeout("verifyWindowSizeAfterNavigateBackToCachedPage()",
1000);

As discussed in person, we have a bug with timers when restoring pages from the
page cache and this timer fires instantly instead of waiting the full second. 
We need a bug on this, to at least explore other browsers' behavior and see
what we should match.

These comments accounted for, r=me


More information about the webkit-reviews mailing list