[webkit-reviews] review granted: [Bug 28081] <video> and <audio> controller should be accessible : [Attachment 38374] revised patch

[bugzilla-daemon at webkit.org]

Oliver Hunt <oliver at apple.com> has granted Eric Carlson
<eric.carlson at apple.com>'s request for review:
Bug 28081: <video> and <audio> controller should be accessible
https://bugs.webkit.org/show_bug.cgi?id=28081

Attachment 38374: revised patch
https://bugs.webkit.org/attachment.cgi?id=38374&action=review

------- Additional Comments from Oliver Hunt <oliver at apple.com>

> +String AccessibilityMediaTimeline::valueDescription() const
> +{
> +    float time =
static_cast<HTMLInputElement*>(m_renderer->node())->value().toFloat();
What is the guarantee that our renderer is an input element?


>  MediaControlMuteButtonElement::MediaControlMuteButtonElement(Document*
document, HTMLMediaElement* element)
> -    : MediaControlInputElement(document, MEDIA_CONTROLS_MUTE_BUTTON,
"button", element, element->muted() ? MediaUnMuteButton : MediaMuteButton)
> +    :: MediaControlInputElement(document, MEDIA_CONTROLS_MUTE_BUTTON,
"button", element)
>  {
>  }
This change looks bogus (:: vs :)

r+ assuming you fix the bogosity and explain why the above cast is safe