[webkit-reviews] review granted: [Bug 28664] Array index miss case creates a string every time : [Attachment 38446] patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Mon Aug 24 11:02:46 PDT 2009


Geoffrey Garen <ggaren at apple.com> has granted Darin Adler <darin at apple.com>'s
request for review:
Bug 28664: Array index miss case creates a string every time
https://bugs.webkit.org/show_bug.cgi?id=28664

Attachment 38446: patch
https://bugs.webkit.org/attachment.cgi?id=38446&action=review

------- Additional Comments from Geoffrey Garen <ggaren at apple.com>
> +    return m_hasIntegralNamedProperty && JSObject::getOwnPropertySlot(exec,
propertyName, slot);

I tend to think that code like this is more readable if the
m_hasIntegralNamedProperty case is an explicit early return. Up to you.

r=me


More information about the webkit-reviews mailing list