[webkit-reviews] review requested: [Bug 26541] CSS property value serialization order is out of whack : [Attachment 38486] A Fix

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Mon Aug 24 10:27:08 PDT 2009

yaar at google.com has asked  for review:
Bug 26541: CSS property value serialization order is out of whack

Attachment 38486: A Fix

------- Additional Comments from yaar at google.com
Yuta's fix is correct and the layout test is wrong. 

WebKit implements CSS3's layered backgrounds, as described here:

With layers, repeat-x, repeat-y isn't equivalent to repeat. Rather, it means
layer 1 should repeat-x and layer 2 should repeat-y. Also, background-image is
by default applied to the last layer. Therefore, the style
"background-color:white; background-repeat: repeat-x,repeat-y" should inded
serialize into: "repeat-x, white repeat-y".

The change list includes Yuta's fix as well as the changes to the layout test
that broke.

p.s. This is my first submission to WebKit. I hope I adhered to all guidelines.

More information about the webkit-reviews mailing list